Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Rehan Ghori. Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60131 )
Change subject: mb/google/hatch/var/scout: improve USB2 port 4 strength ......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60131/comment/e8d6abfc_662aea78 PS1, Line 7: strengh
strength
Done
https://review.coreboot.org/c/coreboot/+/60131/comment/a02b9ef3_4154e23b PS1, Line 8:
What is the problem? What devices do not work?
USB2 port4 SI eye diagram measuring.
https://review.coreboot.org/c/coreboot/+/60131/comment/c6499476_aa9d94cf PS1, Line 9: to 15mv
From what value? (What was it before?) […]
Default USB2_PORT_LONG is 3mV. I builded several testing BIOS for HW measuring USB2 P4 eye diagram. It's from HW's feedback.
https://review.coreboot.org/c/coreboot/+/60131/comment/73204495_84db66f4 PS1, Line 9: mv
mV
Done
File src/mainboard/google/hatch/variants/scout/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/60131/comment/766e7d2c_6a0b4e90 PS1, Line 50: ,,
this is causing a compilation failure
Done
-
Kenneth Chan (Code Review)