Change in ...coreboot[master]: nb/intel/nehalem/raminit.c: Remove variable set but not used
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33004
Change subject: nb/intel/nehalem/raminit.c: Remove variable set but not used ......................................................................
nb/intel/nehalem/raminit.c: Remove variable set but not used
Change-Id: I5d3a04970fa57f07ca7dd748f114ac0cd6955522 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/nehalem/raminit.c 1 file changed, 3 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/33004/1
diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c index 5b6077f..59a4ea3 100644 --- a/src/northbridge/intel/nehalem/raminit.c +++ b/src/northbridge/intel/nehalem/raminit.c @@ -2235,26 +2235,11 @@ u8 lower_usable[8]; u8 upper_usable[8]; unsigned short num_successfully_checked[8]; - u8 secondary_total_rank; u8 reg1b3; + int i;
- if (info->populated_ranks_mask[1]) { - if (channel == 1) - secondary_total_rank = - info->populated_ranks[1][0][0] + - info->populated_ranks[1][0][1] - + info->populated_ranks[1][1][0] + - info->populated_ranks[1][1][1]; - else - secondary_total_rank = 0; - } else - secondary_total_rank = total_rank; - - { - int i; - for (i = 0; i < 8; i++) - state[i] = BEFORE_USABLE; - } + for (i = 0; i < 8; i++) + state[i] = BEFORE_USABLE;
if (!first_run) { int is_all_ok = 1;
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33004
to look at the new patch set (#2).
Change subject: nb/intel/nehalem/raminit.c: Remove variable set but not used ......................................................................
nb/intel/nehalem/raminit.c: Remove variable set but not used
Change-Id: I5d3a04970fa57f07ca7dd748f114ac0cd6955522 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/nehalem/raminit.c 1 file changed, 3 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/33004/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33004
to look at the new patch set (#3).
Change subject: nb/intel/nehalem/raminit.c: Remove variable set but not used ......................................................................
nb/intel/nehalem/raminit.c: Remove variable set but not used
Change-Id: I5d3a04970fa57f07ca7dd748f114ac0cd6955522 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/nehalem/raminit.c 1 file changed, 3 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/33004/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33004 )
Change subject: nb/intel/nehalem/raminit.c: Remove variable set but not used ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33004 )
Change subject: nb/intel/nehalem/raminit.c: Remove variable set but not used ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/33004/5/src/northbridge/intel/nehalem/ramini... File src/northbridge/intel/nehalem/raminit.c:
https://review.coreboot.org/#/c/33004/5/src/northbridge/intel/nehalem/ramini... PS5, Line 2256: I suppose this line is removed due to line 2275, but is 2275 always executed?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33004 )
Change subject: nb/intel/nehalem/raminit.c: Remove variable set but not used ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/33004/5/src/northbridge/intel/nehalem/ramini... File src/northbridge/intel/nehalem/raminit.c:
https://review.coreboot.org/#/c/33004/5/src/northbridge/intel/nehalem/ramini... PS5, Line 2256:
I suppose this line is removed due to line 2275, but is 2275 always executed?
secondary_total_rank is not used at all. and for current 'for(i = 0, ....' loop, please see line #2239 new code
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33004 )
Change subject: nb/intel/nehalem/raminit.c: Remove variable set but not used ......................................................................
nb/intel/nehalem/raminit.c: Remove variable set but not used
Change-Id: I5d3a04970fa57f07ca7dd748f114ac0cd6955522 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33004 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/nehalem/raminit.c 1 file changed, 3 insertions(+), 21 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c index 15d6abb..686089f 100644 --- a/src/northbridge/intel/nehalem/raminit.c +++ b/src/northbridge/intel/nehalem/raminit.c @@ -2235,26 +2235,11 @@ u8 lower_usable[8]; u8 upper_usable[8]; unsigned short num_successfully_checked[8]; - u8 secondary_total_rank; u8 reg1b3; + int i;
- if (info->populated_ranks_mask[1]) { - if (channel == 1) - secondary_total_rank = - info->populated_ranks[1][0][0] + - info->populated_ranks[1][0][1] - + info->populated_ranks[1][1][0] + - info->populated_ranks[1][1][1]; - else - secondary_total_rank = 0; - } else - secondary_total_rank = total_rank; - - { - int i; - for (i = 0; i < 8; i++) - state[i] = BEFORE_USABLE; - } + for (i = 0; i < 8; i++) + state[i] = BEFORE_USABLE;
if (!first_run) { int is_all_ok = 1; @@ -2270,7 +2255,6 @@ is_all_ok = 0; } if (is_all_ok) { - int i; for (i = 0; i < 8; i++) state[i] = COMPLETE; } @@ -2336,7 +2320,6 @@
do { u8 failmask = 0; - int i; for (i = 0; i < niter; i++) { if (failmask == 0xFF) break; @@ -2437,7 +2420,6 @@
do { int failmask = 0; - int i; for (i = 0; i < niter; i++) { if (failmask == 0xFF) break;
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)