Attention is currently required from: V Sowmya, Kedar J. Karanje, Furquan Shaikh, Sridhar Siricilla, Subrata Banik, Vinay Kumar, Ronak Kanabar, Patrick Rudolph, Baieswara Reddy Sagili.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56176 )
Change subject: soc/intel/alderlake: Update the VccIn Aux Imon IccMax for ADL
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/56176/comment/f6859b75_188c451a
PS8, Line 294: 137
Can we calculate these at runtime, so it's easier to see?
So if this is 137 1/4A increments, that's 34.25A overall, so something like:
```
#define MILLIAMPS_TO_AMPS 1000
#define ICC_MAX_ID_ADL_P_3_MA 34250
#define ICC_MAX_ID_ADL_P_5_MA 32000
#define ICC_MAX_ID_ADL_P_7_MA 32000
...
s_cfg->VccInAuxImonIccImax = get_vccin_aux_imon_iccmax() * 4 / MILLIAMPS_TO_AMPS;
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56176
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c159035cba781d3661a0a0cef16f9591a583912
Gerrit-Change-Number: 56176
Gerrit-PatchSet: 8
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Baieswara Reddy Sagili
baieswara.reddy.sagili@intel.com
Gerrit-Reviewer: Kedar J. Karanje
kedar.j.karanje@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Kedar J. Karanje
kedar.j.karanje@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Baieswara Reddy Sagili
baieswara.reddy.sagili@intel.com
Gerrit-Comment-Date: Thu, 29 Jul 2021 21:51:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment