Attention is currently required from: Yu-Ping Wu.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70145 )
Change subject: commonlib: Add essential comments for ELOG_CROS_DIAG_RESULT
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70145/comment/07cafeaa_61e7755d
PS1, Line 13: guidelines
The guideline is at https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/hist...
Not knowing how to put long URL on commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70145
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a1a7c863d5aa9496649f81dc94fd79a6ad482df
Gerrit-Change-Number: 70145
Gerrit-PatchSet: 1
Gerrit-Owner: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 30 Nov 2022 03:57:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment