Change in coreboot[master]: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Chen Wisley (Code Review)

21 Aug 2020 21 Aug '20

11:29 a.m.

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia

drawman/drawlat/drawcia share the same coreboot, and only drawcia is convertible. Use tablet mode of fw config to decide to load custom wifi sar or not.

BUG=b:165613510 TEST=enable CHROMEOS_WIFI_SAR in config of coreboot, emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- A src/mainboard/google/dedede/variants/drawcia/Makefile.inc A src/mainboard/google/dedede/variants/drawcia/variant.c 2 files changed, 28 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44661/1

diff --git a/src/mainboard/google/dedede/variants/drawcia/Makefile.inc b/src/mainboard/google/dedede/variants/drawcia/Makefile.inc new file mode 100755 index 0000000..0013e84 --- /dev/null +++ b/src/mainboard/google/dedede/variants/drawcia/Makefile.inc @@ -0,0 +1,3 @@ +## SPDX-License-Identifier: GPL-2.0-or-later + +ramstage-y += variant.c diff --git a/src/mainboard/google/dedede/variants/drawcia/variant.c b/src/mainboard/google/dedede/variants/drawcia/variant.c new file mode 100755 index 0000000..8ce5475 --- /dev/null +++ b/src/mainboard/google/dedede/variants/drawcia/variant.c @@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <baseboard/variants.h> +#include <ec/google/chromeec/ec.h> +#include <console/console.h> +#include <sar.h> + +#define FW_CONFIG_TABLETMODE_MASK 0x00000400 + +const char *get_wifi_sar_cbfs_filename(void) +{ + const char *filename = NULL; + uint32_t fw_id; + int rev; + + rev = google_chromeec_cbi_get_fw_config(&fw_id); + + if (!rev) { + + if (fw_id & FW_CONFIG_TABLETMODE_MASK) + filename = "wifi_sar-drawcia.hex"; + } + + return filename; +}

Attachments:

attachment.htm (text/html — 4.8 KB)

Show replies by date

build bot (Jenkins) (Code Review)

21 Aug 21 Aug

11:30 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44661/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/variant.c:

https://review.coreboot.org/c/coreboot/+/44661/1/src/mainboard/google/dedede... PS1, Line 18: if (!rev) { code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/44661/1/src/mainboard/google/dedede... PS1, Line 18: if (!rev) { please, no spaces at the start of a line

Chen Wisley (Code Review)

11:32 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44661

to look at the new patch set (#2).

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia

drawman/drawlat/drawcia share the same coreboot, and only drawcia is convertible. Use tablet mode of fw config to decide to load custom wifi sar or not.

BUG=b:165613510 TEST=enable CHROMEOS_WIFI_SAR in config of coreboot, emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44661/2

build bot (Jenkins) (Code Review)

11:33 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44661/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/variant.c:

https://review.coreboot.org/c/coreboot/+/44661/2/src/mainboard/google/dedede... PS2, Line 18: if (!rev){ space required before the open brace '{'

build bot (Jenkins) (Code Review)

11:34 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44661/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/variant.c:

https://review.coreboot.org/c/coreboot/+/44661/3/src/mainboard/google/dedede... PS3, Line 18: if (!rev){ space required before the open brace '{'

Chen Wisley (Code Review)

11:36 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44661

to look at the new patch set (#4).

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia

drawman/drawlat/drawcia share the same coreboot, and only drawcia is convertible. Use tablet mode of fw config to decide to load custom wifi sar or not.

BUG=b:165613510 TEST=enable CHROMEOS_WIFI_SAR in config of coreboot, emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44661/4

Chen Wisley (Code Review)

noon

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44661

to look at the new patch set (#5).

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia

drawman/drawlat/drawcia share the same coreboot, and only drawcia is convertible. Use tablet mode of fw config to decide to load custom wifi sar or not.

BUG=b:165613510 TEST=enable CHROMEOS_WIFI_SAR in config of coreboot, emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44661/5

Justin TerAvest (Code Review)

25 Aug 25 Aug

5:29 p.m.

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 6 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 25 Aug 2020 17:29:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

26 Aug 26 Aug

11:55 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44661/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/variant.c:

https://review.coreboot.org/c/coreboot/+/44661/6/src/mainboard/google/dedede... PS6, Line 16: rev = google_chromeec_cbi_get_fw_config(&fw_id); : : if (!rev) { : : if (fw_id & FW_CONFIG_TABLETMODE_MASK) : filename = "wifi_sar-drawcia.hex"; : } Did you check if you can Firmware Config Interface to do the same. Here is the doc: https://doc.coreboot.org/lib/fw_config.html

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 6 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 26 Aug 2020 23:55:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

4 Sep 4 Sep

10:14 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, Justin TerAvest, Justin TerAvest, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44661

to look at the new patch set (#7).

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia

drawman/drawlat/drawcia share the same coreboot, and only drawcia is convertible. Use tablet mode of fw config to decide to load custom wifi sar or not.

BUG=b:165613510 TEST=enable CHROMEOS_WIFI_SAR in config of coreboot, emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/drawcia/Makefile.inc A src/mainboard/google/dedede/variants/drawcia/fw_config.c M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 5 files changed, 31 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44661/7

build bot (Jenkins) (Code Review)

10:14 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/c/coreboot/+/44661/7/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/fw_config.c:

https://review.coreboot.org/c/coreboot/+/44661/7/src/mainboard/google/dedede... PS7, Line 12: if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_ENABLED))) { braces {} are not necessary for single statement blocks

https://review.coreboot.org/c/coreboot/+/44661/7/src/mainboard/google/dedede... PS7, Line 14: } code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/44661/7/src/mainboard/google/dedede... PS7, Line 14: } please, no spaces at the start of a line

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 7 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 04 Sep 2020 10:14:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

10:17 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, Justin TerAvest, Justin TerAvest, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44661

to look at the new patch set (#8).

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia

drawman/drawlat/drawcia share the same coreboot, and only drawcia is convertible. Use tablet mode of fw config to decide to load custom wifi sar or not.

BUG=b:165613510 TEST=enable CHROMEOS_WIFI_SAR in config of coreboot, emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44661/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 8 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

11:30 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, Justin TerAvest, Justin TerAvest, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44661

to look at the new patch set (#9).

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia

drawman/drawlat/drawcia share the same coreboot, and only drawcia is convertible. Use tablet mode of fw config to decide to load custom wifi sar or not.

BUG=b:165613510 TEST=enable CHROMEOS_WIFI_SAR in config of coreboot, emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/drawcia/Makefile.inc A src/mainboard/google/dedede/variants/drawcia/fw_config.c M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 4 files changed, 31 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44661/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 9 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

11:33 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, Justin TerAvest, Justin TerAvest, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44661

to look at the new patch set (#10).

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia

drawman/drawlat/drawcia share the same coreboot, and only drawcia is convertible. Use tablet mode of fw config to decide to load custom wifi sar or not.

BUG=b:165613510 TEST=enable CHROMEOS_WIFI_SAR in config of coreboot, emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44661/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 10 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

11:34 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, Justin TerAvest, Justin TerAvest, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44661

to look at the new patch set (#11).

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia

drawman/drawlat/drawcia share the same coreboot, and only drawcia is convertible. Use tablet mode of fw config to decide to load custom wifi sar or not.

BUG=b:165613510 TEST=enable CHROMEOS_WIFI_SAR in config of coreboot, emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44661/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 11 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

7 Sep 7 Sep

9:46 a.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44661/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/variant.c:

...

Did you check if you can Firmware Config Interface to do the same. Here is the doc: https://doc. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 11 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 07 Sep 2020 09:46:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

8 Sep 8 Sep

4:05 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 11:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded... File src/mainboard/google/dedede/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded... PS11, Line 23: select FW_CONFIG : select FW_CONFIG_SOURCE_CHROMEEC_CBI This can be moved under BOARD_GOOGLE_BASEBOARD_DEDEDE in Kconfig file since we will use FW_CONFIG for all of dedede. Probably better to split that into a separate patch.

https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded... PS11, Line 2: field TABLETMODE 10 FW_CONFIG bit 10 is used to identify tablet mode for all of dedede. So please move this to variants/baseboard/devicetree.cb. Also as part of the change which moves the FW_CONFIG to Kconfig.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 11 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 08 Sep 2020 16:05:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

9 Sep 9 Sep

2:35 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, Justin TerAvest, Justin TerAvest, Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44661

to look at the new patch set (#12).

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia

drawman/drawlat/drawcia share the same coreboot, and only drawcia is convertible. Use tablet mode of fw config to decide to load custom wifi sar or not.

BUG=b:165613510 TEST=enable CHROMEOS_WIFI_SAR in config of coreboot, emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/drawcia/Makefile.inc A src/mainboard/google/dedede/variants/drawcia/variant.c 3 files changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44661/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 12 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

3:41 a.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 12: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 12 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 09 Sep 2020 03:41:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Chen Wisley (Code Review)

4:28 a.m.

Chen Wisley has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Removed Code-Review+2 by Chen Wisley wisley.chen@quantatw.com

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 12 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: deleteVote

Chen Wisley (Code Review)

8:08 a.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 12:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded... File src/mainboard/google/dedede/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded... PS11, Line 23: select FW_CONFIG : select FW_CONFIG_SOURCE_CHROMEEC_CBI

...

This can be moved under BOARD_GOOGLE_BASEBOARD_DEDEDE in Kconfig file since we will use FW_CONFIG fo […]

Done

https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded... PS11, Line 2: field TABLETMODE 10

...

FW_CONFIG bit 10 is used to identify tablet mode for all of dedede. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 12 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 09 Sep 2020 08:08:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

5:58 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 12: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 12 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 09 Sep 2020 17:58:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Chen Wisley (Code Review)

11 Sep 11 Sep

12:37 p.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 12:

Hi Karthik/Justin,

Could you help to merge it and cherry-pick to chromeos-2016.05 branch?

Thanks

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 12 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 11 Sep 2020 12:37:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

3:50 p.m.

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia

drawman/drawlat/drawcia share the same coreboot, and only drawcia is convertible. Use tablet mode of fw config to decide to load custom wifi sar or not.

BUG=b:165613510 TEST=enable CHROMEOS_WIFI_SAR in config of coreboot, emerge-dedede coreboot-private-files-baseboard-dedede coreboot chromeos-bootimage.

Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44661 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/drawcia/Makefile.inc A src/mainboard/google/dedede/variants/drawcia/variant.c 3 files changed, 21 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name index 40738a0..8c7a51f 100644 --- a/src/mainboard/google/dedede/Kconfig.name +++ b/src/mainboard/google/dedede/Kconfig.name @@ -20,6 +20,7 @@ select BOARD_GOOGLE_BASEBOARD_DEDEDE select BASEBOARD_DEDEDE_LAPTOP select DRIVERS_GENERIC_MAX98357A + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR

config BOARD_GOOGLE_DRAWCIA_LEGACY bool "Drawcia (Legacy)" diff --git a/src/mainboard/google/dedede/variants/drawcia/Makefile.inc b/src/mainboard/google/dedede/variants/drawcia/Makefile.inc new file mode 100644 index 0000000..24c75d1 --- /dev/null +++ b/src/mainboard/google/dedede/variants/drawcia/Makefile.inc @@ -0,0 +1,3 @@ +## SPDX-License-Identifier: GPL-2.0-or-later + +ramstage-$(CONFIG_FW_CONFIG) += variant.c diff --git a/src/mainboard/google/dedede/variants/drawcia/variant.c b/src/mainboard/google/dedede/variants/drawcia/variant.c new file mode 100644 index 0000000..5c969a6 --- /dev/null +++ b/src/mainboard/google/dedede/variants/drawcia/variant.c @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <bootstate.h> +#include <console/console.h> +#include <fw_config.h> +#include <sar.h> + +const char *get_wifi_sar_cbfs_filename(void) +{ + const char *filename = NULL; + + if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_ENABLED))) + filename = "wifi_sar-drawcia.hex"; + + printk(BIOS_INFO, "SAR file name: %s\n", filename); + return filename; +}

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 13 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

Furquan Shaikh (Code Review)

3:59 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44661/13/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/drawcia/variant.c:

https://review.coreboot.org/c/coreboot/+/44661/13/src/mainboard/google/deded... PS13, Line 15: filename Wouldn't this be NULL when TABLETMODE is not set to TABLETMODE_ENABLED?

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 13 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 11 Sep 2020 15:59:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

4:06 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44661/13/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/drawcia/variant.c:

https://review.coreboot.org/c/coreboot/+/44661/13/src/mainboard/google/deded... PS13, Line 15: filename

...

Wouldn't this be NULL when TABLETMODE is not set to TABLETMODE_ENABLED?

Bad overlook on my side. I will upload a CL to fix it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 13 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 11 Sep 2020 16:06:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

4:50 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )

Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44661/13/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/drawcia/variant.c:

https://review.coreboot.org/c/coreboot/+/44661/13/src/mainboard/google/deded... PS13, Line 15: filename

...

Bad overlook on my side. I will upload a CL to fix it.

Added CB:45298 removing this debug statement altogether.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467 Gerrit-Change-Number: 44661 Gerrit-PatchSet: 13 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 11 Sep 2020 16:50:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

1345

days inactive

1366

days old

coreboot-gerrit@coreboot.org

26 comments

5 participants

tags (0)

participants (5)

build bot (Jenkins) (Code Review)
Chen Wisley (Code Review)
Furquan Shaikh (Code Review)
Justin TerAvest (Code Review)
Karthik Ramasubramanian (Code Review)