Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )
Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44661/6/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/drawcia/variant.c:
https://review.coreboot.org/c/coreboot/+/44661/6/src/mainboard/google/dedede...
PS6, Line 16: rev = google_chromeec_cbi_get_fw_config(&fw_id);
:
: if (!rev) {
:
: if (fw_id & FW_CONFIG_TABLETMODE_MASK)
: filename = "wifi_sar-drawcia.hex";
: }
Did you check if you can Firmware Config Interface to do the same. Here is the doc: https://doc. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467
Gerrit-Change-Number: 44661
Gerrit-PatchSet: 11
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 07 Sep 2020 09:46:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment