Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46358 )
Change subject: soc/intel/broadwell/romstage/romstage.c: Clean up includes ......................................................................
soc/intel/broadwell/romstage/romstage.c: Clean up includes
Tested with BUILD_TIMELESS=1, Purism Librem 13 v1 remains identical.
Change-Id: Ibbffe152e511065dc265155555c56446fbb70405 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/romstage/romstage.c 1 file changed, 2 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/46358/1
diff --git a/src/soc/intel/broadwell/romstage/romstage.c b/src/soc/intel/broadwell/romstage/romstage.c index 83e5b73..35792f3 100644 --- a/src/soc/intel/broadwell/romstage/romstage.c +++ b/src/soc/intel/broadwell/romstage/romstage.c @@ -1,12 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stdint.h> +#include <acpi/acpi.h> #include <arch/romstage.h> -#include <cbmem.h> #include <console/console.h> -#include <cpu/x86/mtrr.h> #include <elog.h> -#include <program_loading.h> #include <romstage_handoff.h> #include <timestamp.h> #include <soc/gpio.h> @@ -14,7 +11,7 @@ #include <soc/pei_data.h> #include <soc/pm.h> #include <soc/romstage.h> -#include <soc/spi.h> +#include <stdint.h>
/* Entry from cpu/intel/car/romstage.c. */ void mainboard_romstage_entry(void)
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46358 )
Change subject: soc/intel/broadwell/romstage/romstage.c: Clean up includes ......................................................................
Patch Set 7:
(2 comments)
Not sure what the rules to clean up are here.
https://review.coreboot.org/c/coreboot/+/46358/7/src/soc/intel/broadwell/rom... File src/soc/intel/broadwell/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/46358/7/src/soc/intel/broadwell/rom... PS7, Line 8: #include <timestamp.h> If you want to simply sort it, please alphabetical.
https://review.coreboot.org/c/coreboot/+/46358/7/src/soc/intel/broadwell/rom... PS7, Line 14: #include <stdint.h> It hurts my OCD to see standard headers at the end :-/
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46358 )
Change subject: soc/intel/broadwell/romstage/romstage.c: Clean up includes ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46358/7/src/soc/intel/broadwell/rom... File src/soc/intel/broadwell/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/46358/7/src/soc/intel/broadwell/rom... PS7, Line 8: #include <timestamp.h>
If you want to simply sort it, please alphabetical.
Oops, I missed this one
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46358
to look at the new patch set (#8).
Change subject: soc/intel/broadwell/romstage/romstage.c: Clean up includes ......................................................................
soc/intel/broadwell/romstage/romstage.c: Clean up includes
Tested with BUILD_TIMELESS=1, Purism Librem 13 v1 remains identical.
Change-Id: Ibbffe152e511065dc265155555c56446fbb70405 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/romstage/romstage.c 1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/46358/8
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46358 )
Change subject: soc/intel/broadwell/romstage/romstage.c: Clean up includes ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46358/7/src/soc/intel/broadwell/rom... File src/soc/intel/broadwell/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/46358/7/src/soc/intel/broadwell/rom... PS7, Line 8: #include <timestamp.h>
Oops, I missed this one
Done
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46358 )
Change subject: soc/intel/broadwell/romstage/romstage.c: Clean up includes ......................................................................
Patch Set 8: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46358 )
Change subject: soc/intel/broadwell/romstage/romstage.c: Clean up includes ......................................................................
Patch Set 8: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46358 )
Change subject: soc/intel/broadwell/romstage/romstage.c: Clean up includes ......................................................................
soc/intel/broadwell/romstage/romstage.c: Clean up includes
Tested with BUILD_TIMELESS=1, Purism Librem 13 v1 remains identical.
Change-Id: Ibbffe152e511065dc265155555c56446fbb70405 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46358 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/broadwell/romstage/romstage.c 1 file changed, 3 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Matt DeVillier: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/romstage/romstage.c b/src/soc/intel/broadwell/romstage/romstage.c index 83e5b73..2e5db76 100644 --- a/src/soc/intel/broadwell/romstage/romstage.c +++ b/src/soc/intel/broadwell/romstage/romstage.c @@ -1,20 +1,17 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stdint.h> +#include <acpi/acpi.h> #include <arch/romstage.h> -#include <cbmem.h> #include <console/console.h> -#include <cpu/x86/mtrr.h> #include <elog.h> -#include <program_loading.h> #include <romstage_handoff.h> -#include <timestamp.h> #include <soc/gpio.h> #include <soc/me.h> #include <soc/pei_data.h> #include <soc/pm.h> #include <soc/romstage.h> -#include <soc/spi.h> +#include <stdint.h> +#include <timestamp.h>
/* Entry from cpu/intel/car/romstage.c. */ void mainboard_romstage_entry(void)
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)