Change in coreboot[master]: util/amdfwtool: add MSMU, SPIROM_CFG and DMCUB PSP FW types - coreboot-gerrit

27 Mar 2022


      Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63120 )
Change subject: util/amdfwtool: add MSMU, SPIROM_CFG and DMCUB PSP FW types
......................................................................
Patch Set 3:
(1 comment)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/63120/comment/ff9dfbea_c8c1c2b8 
PS1, Line 315: SPIROM_CONFIG_FILE
...
I really hope we can generate this from the coreboot build...
without having looked into that file format: right now this is a binary, but i agree that in the future this should definitely be generated during the coreboot build
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63120
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa5aacd53b3c7637f6d5e94b1a8d92bba57ddb9d
Gerrit-Change-Number: 63120
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 27 Mar 2022 15:21:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Gerrit-MessageType: comment