build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34396 )
Change subject: mb/google/hatch: Fix SD card is detected as read only issue
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34396/3/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/34396/3/src/mainboard/google/hatch/...
PS3, Line 328: * As per schematics SD host controller SD_WP pin is not connected to uSD card connector.
line over 96 characters
https://review.coreboot.org/c/coreboot/+/34396/3/src/mainboard/google/hatch/...
PS3, Line 329: * In order to overcome gpio default state in hatch, ensures to configure gpio pin as NF1
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34396
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0187267670e1dea3e1d5e83d0b29967714d6065e
Gerrit-Change-Number: 34396
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Medha Garima
medha.garima@intel.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jul 2019 14:18:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment