Attention is currently required from: Paul Menzel, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70164 )
Change subject: mb/google/herobrine: Mask out upper bits from sku_id()
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/70164/comment/f5700cf6_4020de77
PS1, Line 98: 0x1F
Lowercase? 0x1f
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70164
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e786ec392b5e1484cb2ff6d83a8d4fdd698950c
Gerrit-Change-Number: 70164
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-CC: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-CC: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 29 Nov 2022 22:15:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment