Attention is currently required from: Martin Roth, Henry Sun, Tao Xia. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50262 )
Change subject: mb/google/dedede/var/sasukette: Update gpio config and device tree for sasukette ......................................................................
Patch Set 1:
(4 comments)
Patchset:
PS1: I would recommend to split this into individual CLs: 1) Adding camera support in devicetree and associated GPIO configuration 2) Adding Touchpad support into devicetree 3) Adding audio codec and speaker amplifier support into devicetree 4) Adding LTE module support into devicetree and associated GPIO configuartion.
This will make it easy to review the code.
File src/mainboard/google/dedede/variants/sasukette/gpio.c:
https://review.coreboot.org/c/coreboot/+/50262/comment/7afe4d46_8b304eee PS1, Line 9: PLTRST Recommend PWROK to handle the warm reset power sequence requirement for the concerned LTE module.
Also configure the output state to 1.
https://review.coreboot.org/c/coreboot/+/50262/comment/48e72c18_5d2a31f9 PS1, Line 14: /* D0 : WWAN_HOST_WAKE ==> WWAN_WDISABLE_L */ : PAD_CFG_GPO(GPP_D0, 1, DEEP), Is this GPIO being used. What LTE module is used in Sasukette?
https://review.coreboot.org/c/coreboot/+/50262/comment/80852d56_33a320d3 PS1, Line 20: 1, Why is this 1. Is the signal inverted somewhere between the GPIO and the LTE module?