Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32508 )
Change subject: soc/intel/icelake: Correct the GPE DWx mapping for GPIO groups
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32508/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32508/1//COMMIT_MSG@9
PS1, Line 9: This patch ports CB:32175 changes from CNL to ICL.
mapping for CNL is very different than ICL, isn't it?
agree, i have removed this line in PS2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32508
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c306d46e5194944def26c24cdb95f5ebada42b8
Gerrit-Change-Number: 32508
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Apr 2019 03:20:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment