Change in coreboot[master]: lib/Makefile.inc: fail build when SPD would be empty

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45131 )

Change subject: lib/Makefile.inc: fail build when SPD would be empty
......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45131/14/src/lib/Makefile.inc 
File src/lib/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/45131/14/src/lib/Makefile.inc@360 
PS14, Line 360: test -n "$(SPD_SOURCES)" || \
              : 	    (echo "HAVE_SPD_BIN_IN_CBFS is set but SPD_SOURCES is empty" && exit 1)
> > I'd rather avoid getting such incomplete states of board variants into the tree. […]

Thanks for the detailed explanation. I wasn't aware that some of these ports are for boards that do not exist yet. I'm fine with this approach to adding new variants, as it seems to address the copy-paste problem rather well. However, completely dropping the `spd file would be empty` build-time check is IMHO unacceptable.

If the type of memory a new variant is known at creation time, it's just a matter of using the right empty SPD file (why are they within soc/ though???). Otherwise, I would just use the baseboard default. And if that still caused problems, why not use a generic`fixme_empty_spd_placeholder.hex` file?