Change in coreboot[master]: util/inteltool: gpio: add Sunrise Point GPIO Community config registers
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39512 )
Change subject: util/inteltool: gpio: add Sunrise Point GPIO Community config registers ......................................................................
Patch Set 11:
(3 comments)
The numbers seem correct, but why does everything look red know? ^^
https://review.coreboot.org/c/coreboot/+/39512/8/util/inteltool/gpio_names/s... File util/inteltool/gpio_names/sunrise.h:
https://review.coreboot.org/c/coreboot/+/39512/8/util/inteltool/gpio_names/s... PS8, Line 8: C please keep the lower-case hex style.
https://review.coreboot.org/c/coreboot/+/39512/8/util/inteltool/gpio_names/s... PS8, Line 34: }; also applies to LP version
https://review.coreboot.org/c/coreboot/+/39512/8/util/inteltool/gpio_names/s... PS8, Line 581: .community_cfg_registers_size = ARRAY_SIZE(sunrise_community_ab_cfg_registers), Please maintain alignment of the =
-
Nico Huber (Code Review)