Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47813 )
Change subject: Doc/releases/checklist.md: Clarify tag push command ......................................................................
Doc/releases/checklist.md: Clarify tag push command
Change-Id: I0a6d1ed014c6454c4bde390283351c19fe097201 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Documentation/releases/checklist.md 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/47813/1
diff --git a/Documentation/releases/checklist.md b/Documentation/releases/checklist.md index d777f0e..e4fb5e9 100644 --- a/Documentation/releases/checklist.md +++ b/Documentation/releases/checklist.md @@ -178,7 +178,8 @@ ````
When you used the script to generate the release, a tag was generated in the tree that was downloaded. -From the coreboot-X.Y tree, just run: `git push -f origin <TAG (X.Y)>` +From the coreboot-X.Y tree, just run: `git push origin X.Y`. Force-pushing may sometimes be +necessary to push the new tag.
You will need write access for tags to the coreboot git repo to do this.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47813 )
Change subject: Doc/releases/checklist.md: Clarify tag push command ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47813/2/Documentation/releases/chec... File Documentation/releases/checklist.md:
https://review.coreboot.org/c/coreboot/+/47813/2/Documentation/releases/chec... PS2, Line 180: a tag since you asked me about that step: "a signed tag"?
https://review.coreboot.org/c/coreboot/+/47813/2/Documentation/releases/chec... PS2, Line 181: Force-pushing may sometimes be : necessary to push the new tag. "In case you pushed the wrong tag already, you have to force push the new one."
Hello build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47813
to look at the new patch set (#3).
Change subject: Doc/releases/checklist.md: Clarify tag push command ......................................................................
Doc/releases/checklist.md: Clarify tag push command
Change-Id: I0a6d1ed014c6454c4bde390283351c19fe097201 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Documentation/releases/checklist.md 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/47813/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47813 )
Change subject: Doc/releases/checklist.md: Clarify tag push command ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47813/2/Documentation/releases/chec... File Documentation/releases/checklist.md:
https://review.coreboot.org/c/coreboot/+/47813/2/Documentation/releases/chec... PS2, Line 180: a tag
since you asked me about that step: "a signed tag"?
Done
https://review.coreboot.org/c/coreboot/+/47813/2/Documentation/releases/chec... PS2, Line 181: Force-pushing may sometimes be : necessary to push the new tag.
"In case you pushed the wrong tag already, you have to force push the new one. […]
Done
Hello build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47813
to look at the new patch set (#4).
Change subject: Doc/releases/checklist.md: Clarify tag push command ......................................................................
Doc/releases/checklist.md: Clarify tag push command
Change-Id: I0a6d1ed014c6454c4bde390283351c19fe097201 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Documentation/releases/checklist.md 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/47813/4
Attention is currently required from: Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47813 )
Change subject: Doc/releases/checklist.md: Clarify tag push command ......................................................................
Patch Set 5: Code-Review+1
Attention is currently required from: Nico Huber, Martin Roth, Stefan Reinauer, Arthur Heymans. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47813 )
Change subject: Doc/releases/checklist.md: Clarify tag push command ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47813 )
Change subject: Doc/releases/checklist.md: Clarify tag push command ......................................................................
Doc/releases/checklist.md: Clarify tag push command
Change-Id: I0a6d1ed014c6454c4bde390283351c19fe097201 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47813 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/releases/checklist.md 1 file changed, 3 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/Documentation/releases/checklist.md b/Documentation/releases/checklist.md index d777f0e..3f19bfb 100644 --- a/Documentation/releases/checklist.md +++ b/Documentation/releases/checklist.md @@ -177,8 +177,9 @@ ... ````
-When you used the script to generate the release, a tag was generated in the tree that was downloaded. -From the coreboot-X.Y tree, just run: `git push -f origin <TAG (X.Y)>` +When you used the script to generate the release, a signed tag was generated in the +tree that was downloaded. From the coreboot-X.Y tree, just run: `git push origin X.Y`. +In case you pushed the wrong tag already, you have to force push the new one.
You will need write access for tags to the coreboot git repo to do this.
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)