Change in coreboot[master]: mb/google/hatch: Add support for variant_devtree_update()

[David Wu (Code Review)]

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34399 )

Change subject: mb/google/hatch: Add support for variant_devtree_update()
......................................................................

mb/google/hatch: Add support for variant_devtree_update()

This change adds support for variant_devtree_update()
that allows variant to update device tree.

BUG=None
TEST=emerge-hatch coreboot chromeos-bootimage

Change-Id: I0e9ad360b6c02c83fe49387ce7bc66d56448ffb9
Signed-off-by: David Wu 
---
M src/mainboard/google/hatch/ramstage.c
M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h
2 files changed, 9 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/34399/1

diff --git a/src/mainboard/google/hatch/ramstage.c b/src/mainboard/google/hatch/ramstage.c
index 3436007..0107a54 100644
--- a/src/mainboard/google/hatch/ramstage.c
+++ b/src/mainboard/google/hatch/ramstage.c
@@ -30,13 +30,18 @@

base_table = base_gpio_table(&base_gpios);
    override_table = override_gpio_table(&override_gpios);
-
+	variant_devtree_update();
    gpio_configure_pads_with_override(base_table,
    				base_gpios,
    				override_table,
    				override_gpios);
 }

+void __weak variant_devtree_update(void)
+{
+	/* Override dev tree settings per board */
+}
+
 static void mainboard_enable(struct device *dev)
 {
    mainboard_ec_init();
diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h
index 17bd5df..fa43903 100644
--- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h
+++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h
@@ -40,4 +40,7 @@
 /* Return ChromeOS gpio table and fill in number of entries. */
 const struct cros_gpio *variant_cros_gpios(size_t *num);

+/* Modify devictree settings during ramstage. */
+void variant_devtree_update(void);
+
 #endif /* BASEBOARD_VARIANTS_H */

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34399 )

Change subject: mb/google/hatch: Add support for variant_devtree_update()
......................................................................

Patch Set 1: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34399 )

Change subject: mb/google/hatch: Add support for variant_devtree_update()
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34399/1/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/ramstage.c:

https://review.coreboot.org/c/coreboot/+/34399/1/src/mainboard/google/hatch/... 
PS1, Line 33: 	variant_devtree_update();
nit: Doesn't make a difference w.r.t. functionality, but rest of the lines are dealing with getting and configuring gpio table. It would be good to place this before "base_table = ..." above or after "gpio_configure_pads_with_override(...)" just to logically group the operations being performed.

[David Wu (Code Review)]

Hello Paul Fagerburg, Paul Fagerburg, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34399

to look at the new patch set (#2).

Change subject: mb/google/hatch: Add support for variant_devtree_update()
......................................................................

mb/google/hatch: Add support for variant_devtree_update()

This change adds support for variant_devtree_update()
that allows variant to update device tree.

BUG=None
TEST=emerge-hatch coreboot chromeos-bootimage

Change-Id: I0e9ad360b6c02c83fe49387ce7bc66d56448ffb9
Signed-off-by: David Wu 
---
M src/mainboard/google/hatch/ramstage.c
M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h
2 files changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/34399/2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34399 )

Change subject: mb/google/hatch: Add support for variant_devtree_update()
......................................................................

Patch Set 2: Code-Review+2

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34399 )

Change subject: mb/google/hatch: Add support for variant_devtree_update()
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34399/1/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/ramstage.c:

https://review.coreboot.org/c/coreboot/+/34399/1/src/mainboard/google/hatch/... 
PS1, Line 33: 	variant_devtree_update();
> nit: Doesn't make a difference w.r.t. […]

Done

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34399 )

Change subject: mb/google/hatch: Add support for variant_devtree_update()
......................................................................

mb/google/hatch: Add support for variant_devtree_update()

This change adds support for variant_devtree_update()
that allows variant to update device tree.

BUG=None
TEST=emerge-hatch coreboot chromeos-bootimage

Change-Id: I0e9ad360b6c02c83fe49387ce7bc66d56448ffb9
Signed-off-by: David Wu 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34399
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
---
M src/mainboard/google/hatch/ramstage.c
M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h
2 files changed, 9 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/ramstage.c b/src/mainboard/google/hatch/ramstage.c
index 3436007..04e1bc1 100644
--- a/src/mainboard/google/hatch/ramstage.c
+++ b/src/mainboard/google/hatch/ramstage.c
@@ -28,6 +28,7 @@
    size_t base_gpios;
    size_t override_gpios;

+	variant_devtree_update();
    base_table = base_gpio_table(&base_gpios);
    override_table = override_gpio_table(&override_gpios);

@@ -37,6 +38,11 @@
    				override_gpios);
 }

+void __weak variant_devtree_update(void)
+{
+	/* Override dev tree settings per board */
+}
+
 static void mainboard_enable(struct device *dev)
 {
    mainboard_ec_init();
diff --git a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h
index 864d140..4cb1194 100644
--- a/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h
+++ b/src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h
@@ -43,4 +43,7 @@
 /* Return ChromeOS gpio table and fill in number of entries. */
 const struct cros_gpio *variant_cros_gpios(size_t *num);

+/* Modify devictree settings during ramstage. */
+void variant_devtree_update(void);
+
 #endif /* BASEBOARD_VARIANTS_H */