Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33759 )
Change subject: soc/amd/picasso: Create a hybrid romstage to begin in DRAM
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33759/5/src/soc/amd/picasso/reset_v...
File src/soc/amd/picasso/reset_vector.S:
https://review.coreboot.org/c/coreboot/+/33759/5/src/soc/amd/picasso/reset_v...
PS5, Line 145: and $0xfffffff0, %esp
Are you certain? I thought I recalled that functions should have their stack in alignment at the mo […]
I was looking at cpu/intel/car/non-evict/cache_as_ram.S as reference.
https://review.coreboot.org/c/coreboot/+/33759/5/src/soc/amd/picasso/reset_v...
PS5, Line 154: call hybrid_romstage_entry
Good suggestion
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33759
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8c6175de34a0728ad41085e9c7cd310bd280976
Gerrit-Change-Number: 33759
Gerrit-PatchSet: 6
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 26 Jul 2019 04:47:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment