Change in coreboot[master]: include/device/i2c_simple: add i2c_read_eeprom_bytes function - coreboot-gerrit

23 Apr 2022


      Attention is currently required from: Raul Rangel, Felix Held.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63791 )
Change subject: include/device/i2c_simple: add i2c_read_eeprom_bytes function
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: 
No objections but I feel that the name `eeprom` is a bit overly specific here. All this is is a version of read_bytes() that uses a 16-bit register address. Can we find a more systematic name for that? Maybe i2c_readw_bytes() or i2c_read16_bytes()?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I224e434bb2654aabef6302c1525112e44c4b21fa
Gerrit-Change-Number: 63791
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 23 Apr 2022 00:39:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment