Patrick Georgi (pgeorgi@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12429
-gerrit
commit 4466265a695d40fa26be8bc3c3350ff6b3726236 Author: Patrick Georgi pgeorgi@chromium.org Date: Fri Nov 13 09:39:22 2015 +0100
sconfig: remove warning about root_complex
It's not deprecated if it's still in active use. The code layout is just "funny" (and could warrant a chipset-side cleanup, but not today)
Change-Id: I5f7776ceba0134f20364a0c4a1ca51382e9877e2 Signed-off-by: Patrick Georgi pgeorgi@chromium.org --- util/sconfig/main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/sconfig/main.c b/util/sconfig/main.c index 5eb74da..27027f5 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -164,10 +164,10 @@ struct device *new_chip(struct device *parent, struct device *bus, char *path) { char *chip_h = malloc(strlen(path)+18); sprintf(chip_h, "src/%s", path); if ((stat(chip_h, &st) == -1) && (errno == ENOENT)) { - if (strstr(path, "/root_complex")) { - fprintf(stderr, "WARNING: Use of deprecated chip component %s\n", - path); - } else { + /* root_complex gets away without a separate directory, but + * exists on on pretty much all AMD chipsets. + */ + if (!strstr(path, "/root_complex")) { fprintf(stderr, "ERROR: Chip component %s does not exist.\n", path); exit(1);