[S] Change in coreboot[main]: soc/amd/common/block/lpc: Add ROM2 and ROM3 helper functions - coreboot-gerrit

25 Feb 2025


      Attention is currently required from: Ana Carolina Cabral, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86583?usp=email )
Change subject: soc/amd/common/block/lpc: Add ROM2 and ROM3 helper functions
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/lpc.h:
https://review.coreboot.org/c/coreboot/+/86583/comment/91ec18fb_af296f3b?usp... :
PS1, Line 106: ROM_ADDRESS_RANGE3_START
...
Move this up, after ROM_ADDRESS_RANGE2_END.
Shouldn't it be moved down after LPC_WIDEIO2_GENERIC_PORT to keep numerical order?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/86583?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I10d4f0fe8a38e0ba2784a9839270d5dd3398d47a
Gerrit-Change-Number: 86583
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Ana Carolina Cabral ana.cpmelo95@gmail.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Ana Carolina Cabral ana.cpmelo95@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 25 Feb 2025 08:43:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ana Carolina Cabral ana.cpmelo95@gmail.com