Attention is currently required from: Arthur Heymans, Cliff Huang, Felix Singer, Fred Reitberger, Jason Glenesk, Jeff Daly, Lance Zhao, Matt DeVillier, Raul Rangel, Tim Wawrzynczak, Vanessa Eusebio.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76128?usp=email )
Change subject: acpi: Move HPET generation to a common location
......................................................................
Patch Set 9: Code-Review+1
(4 comments)
Patchset:
PS9:
Looks good overall and I like it!
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76128/comment/2e3c94ca_dc2d5253 :
PS9, Line 1266: #endif
A `static inline` with these guards in the header file at the forward
declaration might look better than #if in a C file.
File src/acpi/acpi_hpet.c:
https://review.coreboot.org/c/coreboot/+/76128/comment/134a514c_42532e9c :
PS9, Line 13: return;
It's already guarded in the Makefile, so not necessary here, right?
(I guess we could also keep this, remove the guard in the Makefile
and safe us the #if'ed stub above?)
File src/southbridge/intel/i82371eb/Kconfig:
https://review.coreboot.org/c/coreboot/+/76128/comment/16eed369_e5c1bbc8 :
PS9, Line 12: config ACPI_HPET
There's no I82371EB specific guard here, so this could be leaking, right?
Why not have a `select ACPI_HPET if HAVE_ACPI_TABLES` above?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76128?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I38b9962a8d568267356256a3edc51348b9417e20
Gerrit-Change-Number: 76128
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Wed, 01 Nov 2023 00:26:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment