Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Ravindra, Sridhar Siricilla, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55364 )
Change subject: soc/intel/alderlake: Trigger cse_fw_sync before DRAM Init
......................................................................
Patch Set 12:
(2 comments)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/55364/comment/381c0fb2_8546c0cf
PS12, Line 145: cse_fw_sync() must be called after DRAM initialization as
: * HMRFPO_ENABLE HECI command (which is used by cse_fw_sync())
: * is expected to be executed after DRAM initialization.
As part of cse_fw_sync(), coreboot sends few commands like GET BOOT PARTITION INFO, SET BOOT PARTITI […]
Thanks for explanation and can you please write the same to the commit msg for record so folks don't run into issue while integration latest code with older binary (if any?)
https://review.coreboot.org/c/coreboot/+/55364/comment/43c41d11_bccfc794
PS12, Line 140:
We can add, I will push the updated patch.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55364
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad7403650df8bc4e40aa6e48ccfeba95a5789a2d
Gerrit-Change-Number: 55364
Gerrit-PatchSet: 12
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ravindra
ravindra@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 23 Nov 2021 09:47:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment