Attention is currently required from: Damien Zammit, Angel Pons, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49389 )
Change subject: nb/intel/x4x: Drop commented-out statement
......................................................................
Patch Set 1:
(1 comment)
File src/northbridge/intel/x4x/raminit_ddr23.c:
https://review.coreboot.org/c/coreboot/+/49389/comment/9b8a75c8_35a8e780
PS1, Line 775: MCHBAR8_AND(0x400 * i + 0x5a0 + 3,
: ~rank2clken[r + i * 4]);
I do remember that I needed this to have all clock signals enabled for a (DDR3) board to work (better, there still were other issues). I guess its wiring differed from the reference design?
I'll send a patch
https://review.coreboot.org/c/coreboot/+/50353
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49389
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff4cdd71435e4fd69d4f3284e9fb2830fdd5b173
Gerrit-Change-Number: 49389
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 06 Feb 2021 08:42:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment