Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59557 )
Change subject: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/volteer/variants/delbin/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134072):
https://review.coreboot.org/c/coreboot/+/59557/comment/46b96cea_a4c6c9c9
PS2, Line 2: #include <fw_config.h>
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134072):
https://review.coreboot.org/c/coreboot/+/59557/comment/b72e8ec2_22230ea9
PS2, Line 24: config->hid = "RTL5682";
trailing whitespace
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59557
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieef638f78edd3428e572a76f06fb9c8757278971
Gerrit-Change-Number: 59557
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 23 Nov 2021 04:14:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment