Attention is currently required from: Mario Scheithauer, Arthur Heymans.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 )
Change subject: drivers/net/phy/m88e1512: Provide functionality to customize LED status ......................................................................
Patch Set 14: Code-Review+1
(3 comments)
File src/drivers/net/phy/m88e1512/m88e1512.c:
https://review.coreboot.org/c/coreboot/+/69386/comment/102cf51d_6a0a9db5 PS14, Line 20: configure_leds is set. nit: Just 'requested' would sound better here IMO. But up to you to decide.
File src/drivers/phy/m88e1512/m88e1512.c:
https://review.coreboot.org/c/coreboot/+/69386/comment/03c37eff_8a663262 PS10, Line 18: : const struct mdio_operations *mdio_ops; : struct device *parent = dev->bus->dev;
This is bit tidious to add to every read/write op. […]
Ack
https://review.coreboot.org/c/coreboot/+/69386/comment/28b98485_a50f851f PS10, Line 34: path
Check type if it is indeed an MDIO device.
Ack