Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29204 )
Change subject: ec/lenovo/h8: Add function to query sense state
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/29204/2/src/ec/lenovo/h8/sense.c
File src/ec/lenovo/h8/sense.c:
https://review.coreboot.org/#/c/29204/2/src/ec/lenovo/h8/sense.c@25
PS2, Line 25: * Unlikely that all register will be zero after booting has
: * finished.
So far I understood, the EC reboots when powering the laptop on.
Patrick, I still wonder what this sentence refers to,
coreboot boot process? the EC's?
If it's the EC, the statement may be true, but it
doesn't work the other way. i.e. doesn't imply that
the EC finished populating these registers, when we
see the first bit set.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29204
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie27e2881a256c4efb3def11f05070c446db6e5fc
Gerrit-Change-Number: 29204
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 06 May 2019 12:02:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Couzens
lynxis@fe80.eu
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment