Change in coreboot[master]: src/cpu/x86/smm: move console init to thread safe section

[Rocky Phagura (Code Review)]

Attention is currently required from: Nico Huber, Jonathan Zhang, David Hendricks, Rocky Phagura, Angel Pons, Arthur Heymans.
Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52518 )

Change subject: src/cpu/x86/smm: move console init to thread safe section
......................................................................

Patch Set 1:

(1 comment)

File src/cpu/x86/smm/smm_module_handler.c:

https://review.coreboot.org/c/coreboot/+/52518/comment/3074d405_e674474f 
PS1, Line 149: 	if (cpu > CONFIG_MAX_CPUS) {
> You can detect this before or during MP-init.

So I'm still not convinced. Regardless of the configuration and where its detected, this code is not thread safe. It causes hangs and makes Coreboot less robust. At the time of the hang, there is no console messages available and the hang occurs within in SMM. These requires a hardware debugger to root cause the issue.

If max CPU config is checked earlier during MP init and its an illegal config, then the system should be halted at that point, thus making this code not applicable.