Attention is currently required from: John Su, Nick Vaccaro, Eric Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63099 )
Change subject: mb/google/brya: Demote EC check message level from error to warning
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
@Tim, We probably can ignore CBI command with -3 return. keep other errors. […]
You will see this error I think if not all of the CBI fields are set up correctly, e.g. OEM_NAME, make sure all CBI fields are set up correctly and try re-running the test
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63099
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I83d3eec6dba7b8cd006b58b93a7c53842ad6ce0a
Gerrit-Change-Number: 63099
Gerrit-PatchSet: 2
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 25 Mar 2022 15:38:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment