16 Aug
2018
16 Aug
'18
11:42 p.m.
Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/28112 )
Change subject: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/devicetree.cb:
https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants/... PS1, Line 312: register "reg_prox_ctrl10" = "0x1F" nit: 1f
https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants/... PS1, Line 353: register "reg_prox_ctrl10" = "0x1F" nit: 1f
--
To view, visit https://review.coreboot.org/28112
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571
Gerrit-Change-Number: 28112
Gerrit-PatchSet: 1
Gerrit-Owner: Enrico Granata egranata@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Gwendal Grignou gwendal@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 16 Aug 2018 23:42:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
2297
days inactive
2297
days old
0 comments
1 participants
participants (1)
-
Gwendal Grignou (Code Review)