Attention is currently required from: Raul Rangel, Furquan Shaikh, Marshall Dawson, Julius Werner, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55856 )
Change subject: commonlib/region: Add support for asynchronous readat ......................................................................
Patch Set 4:
(6 comments)
File src/commonlib/include/commonlib/region.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123305): https://review.coreboot.org/c/coreboot/+/55856/comment/7c15f0f3_fab0b140 PS4, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'const struct region_device *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123305): https://review.coreboot.org/c/coreboot/+/55856/comment/e73eba4e_d874ea7b PS4, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'struct rdev_readat_async_context *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123305): https://review.coreboot.org/c/coreboot/+/55856/comment/f25d840a_74eb451a PS4, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'void *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123305): https://review.coreboot.org/c/coreboot/+/55856/comment/7763a9dd_799c25c7 PS4, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'size_t' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123305): https://review.coreboot.org/c/coreboot/+/55856/comment/182ef0ce_8c02925a PS4, Line 98: cb_err_t (*readat_async)(const struct region_device *, function definition argument 'size_t' should also have an identifier name
File src/commonlib/region.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123305): https://review.coreboot.org/c/coreboot/+/55856/comment/27eea7e4_9737b02b PS4, Line 136: cb_err_t rdev_readat_async(const struct region_device *rd, struct rdev_readat_async_context *context, line over 96 characters