Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86912?usp=email )
Change subject: mb/starlabs/starbook/mtl: Don't set rcomp config ......................................................................
mb/starlabs/starbook/mtl: Don't set rcomp config
Leave the rcomp config empty so that 0's are passed to FSP; this allows FSP to figure out the correct settings to use.
Change-Id: Id7d44984c5ecfd0307d207d997248e88e1bd6eb4 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86912 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/starbook/variants/mtl/romstage.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/variants/mtl/romstage.c b/src/mainboard/starlabs/starbook/variants/mtl/romstage.c index b593a8c..acd384e 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/romstage.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/romstage.c @@ -11,10 +11,6 @@ .type = MEM_TYPE_DDR5, .ect = true, .UserBd = BOARD_TYPE_ULT_ULX, - .rcomp = { - .resistor = 100, - .targets = {70, 30, 25, 25, 25}, - } };
const bool half_populated = false;