Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38824 )
Change subject: soc/intel/apollolake: Display platform information ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38824/4/src/soc/intel/apollolake/re... File src/soc/intel/apollolake/report_platform.c:
https://review.coreboot.org/c/coreboot/+/38824/4/src/soc/intel/apollolake/re... PS4, Line 79: u32 i
Yes i have made all the counting variables `unsigned int`in the new patch set
Done
https://review.coreboot.org/c/coreboot/+/38824/6/src/soc/intel/apollolake/re... File src/soc/intel/apollolake/report_platform.c:
https://review.coreboot.org/c/coreboot/+/38824/6/src/soc/intel/apollolake/re... PS6, Line 4: * Copyright (C) 2020 Intel Corporation.
Remove the dot at the end.
Done
https://review.coreboot.org/c/coreboot/+/38824/6/src/soc/intel/apollolake/re... PS6, Line 103: cpu_id, cpu_type, microcode_ver.hi);
Fits on one line?
Done
https://review.coreboot.org/c/coreboot/+/38824/6/src/soc/intel/apollolake/re... PS6, Line 106: aes_supported = (cpu_feature_flag & CPUID_AES) ? 1 : 0;
Sorry, I did not check. […]
Done
https://review.coreboot.org/c/coreboot/+/38824/6/src/soc/intel/apollolake/re... PS6, Line 172: report_igd_info();
Can you make some parts of that common code?
Yes. This will be taken care in the common code related patches. https://review.coreboot.org/c/coreboot/+/25810 is WIP patch which will handle the common part of report_platform.c code
-
Usha P (Code Review)