[XS] Change in coreboot[main]: drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume

[Jonathon Hall (Code Review)]

Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78288?usp=email )

Change subject: drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume
......................................................................

Patch Set 8:

(1 comment)

Patchset:

PS4:
> It's still not really nice what we do with this odd static-option-table […]

I can't speak to the original purpose, but I use it currently to offer SeaBIOS ROMs for Mini v1/v2 that always enable the EC's automatic power-on.  The EC implements that, so the setting has to be written to CMOS (which is EC BRAM here) to work.

The logic change above would still work with that, with an added benefit that if the CMOS was fiddled before or during suspend, it'd be reset on resume like you said.