Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29916 )
Change subject: Fix coreboot table record alignment to 8-byte boundary
......................................................................
Patch Set 5:
Why are we doing this? The coreboot table has always had unaligned
records. It's the responsibility of the caller to deal with that.
Yes, the coreboot table can be unaligned records. But this will cause a lot of misaligned memory access exceptions, such as adding some padding will not affect the program to run
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29916
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1846be0e26ab3c81858d8cf727517e1462035e64
Gerrit-Change-Number: 29916
Gerrit-PatchSet: 5
Gerrit-Owner: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn C
citypw@gmail.com
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Tue, 05 Feb 2019 04:09:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment