Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62065 )
Change subject: src/mediatek/mt8186: Implement sdram_size() to get real dram size
......................................................................
Patch Set 21:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62065/comment/415bed8a_d7bfe249
PS20, Line 9: set to 4GB by default
hard-coded to 4GB
Done
File src/soc/mediatek/mt8186/emi.c:
https://review.coreboot.org/c/coreboot/+/62065/comment/e3a0ae47_777550bb
PS20, Line 28: channel = (void *)((uintptr_t)mc + sizeof(*mc));
Please fix this.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62065
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I017e9d1a2d6e26f1fc21b67b5962dfb5c6ade8a5
Gerrit-Change-Number: 62065
Gerrit-PatchSet: 21
Gerrit-Owner: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 22 Mar 2022 06:08:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment