Hello Jason Glenesk,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44325
to review the following change.
Change subject: /soc/amd/picasso Correct processor scope for picasso ......................................................................
/soc/amd/picasso Correct processor scope for picasso
Change namespace from _PR to _SB.
Cq-Depend: chrome-internal:3208104 BUG=b:153242529 TEST=Boot a trembyle with change applied and dump SSDTs to ensure processors are in _SB scope.
Change-Id: I534f02dc50756759da945cf64d5b3623b0ec9db1 Signed-off-by: Jason Glenesk jason.glenesk@amd.corp-partner.google.com --- M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/acpi/cpu.asl 2 files changed, 24 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/44325/1
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 526900a..8001b7a 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -321,7 +321,7 @@
config ACPI_CPU_STRING string - default "\_PR.C%03d" + default "\_SB.C%03d"
config ACPI_BERT bool "Build ACPI BERT Table" diff --git a/src/soc/amd/picasso/acpi/cpu.asl b/src/soc/amd/picasso/acpi/cpu.asl index 8b61b8f..eb646de 100644 --- a/src/soc/amd/picasso/acpi/cpu.asl +++ b/src/soc/amd/picasso/acpi/cpu.asl @@ -36,14 +36,14 @@ * Processor Object */ /* These devices are created at runtime */ -External (_PR.C000, DeviceObj) -External (_PR.C001, DeviceObj) -External (_PR.C002, DeviceObj) -External (_PR.C003, DeviceObj) -External (_PR.C004, DeviceObj) -External (_PR.C005, DeviceObj) -External (_PR.C006, DeviceObj) -External (_PR.C007, DeviceObj) +External (_SB.C000, DeviceObj) +External (_SB.C001, DeviceObj) +External (_SB.C002, DeviceObj) +External (_SB.C003, DeviceObj) +External (_SB.C004, DeviceObj) +External (_SB.C005, DeviceObj) +External (_SB.C006, DeviceObj) +External (_SB.C007, DeviceObj)
/* Return a package containing enabled processor entries */ Method (PPKG) @@ -51,33 +51,33 @@ If (LGreaterEqual (\PCNT, 8)) { Return (Package () { - _PR.C000, - _PR.C001, - _PR.C002, - _PR.C003, - _PR.C004, - _PR.C005, - _PR.C006, - _PR.C007 + _SB.C000, + _SB.C001, + _SB.C002, + _SB.C003, + _SB.C004, + _SB.C005, + _SB.C006, + _SB.C007 }) } ElseIf (LGreaterEqual (\PCNT, 4)) { Return (Package () { - _PR.C000, - _PR.C001, - _PR.C002, - _PR.C003 + _SB.C000, + _SB.C001, + _SB.C002, + _SB.C003 }) } ElseIf (LGreaterEqual (\PCNT, 2)) { Return (Package () { - _PR.C000, - _PR.C001 + _SB.C000, + _SB.C001 }) } Else { Return (Package () { - _PR.C000 + _SB.C000 }) } }
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44325 )
Change subject: /soc/amd/picasso Correct processor scope for picasso ......................................................................
Patch Set 1:
Please help to review this change.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44325 )
Change subject: /soc/amd/picasso Correct processor scope for picasso ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44325/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44325/1//COMMIT_MSG@7 PS1, Line 7: /soc/amd/picasso Correct processor scope for picasso A few nits: - no leading `/` - add a colon `:` at the end - the `for picasso` at the end is redundant, because of the prefix
soc/amd/picasso: Correct processor scope
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44325 )
Change subject: /soc/amd/picasso Correct processor scope for picasso ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44325/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44325/1//COMMIT_MSG@7 PS1, Line 7: /soc/amd/picasso Correct processor scope for picasso
A few nits: […]
maybe "soc/amd/picasso: Correct processor ACPI scope"?
Hello build bot (Jenkins), Martin Roth, Jason Glenesk, Angel Pons, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44325
to look at the new patch set (#2).
Change subject: soc/amd/picasso: Correct processor scope ......................................................................
soc/amd/picasso: Correct processor scope
Change namespace from _PR to _SB.
Cq-Depend: chrome-internal:3208104 BUG=b:153242529 TEST=Boot a trembyle with change applied and dump SSDTs to ensure processors are in _SB scope.
Change-Id: I534f02dc50756759da945cf64d5b3623b0ec9db1 Signed-off-by: Jason Glenesk jason.glenesk@amd.corp-partner.google.com --- M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/acpi/cpu.asl 2 files changed, 24 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/44325/2
Hello build bot (Jenkins), Martin Roth, Jason Glenesk, Angel Pons, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44325
to look at the new patch set (#3).
Change subject: soc/amd/picasso: Correct processor ACPI scope ......................................................................
soc/amd/picasso: Correct processor ACPI scope
Change namespace from _PR to _SB.
Cq-Depend: chrome-internal:3208104 BUG=b:153242529 TEST=Boot a trembyle with change applied and dump SSDTs to ensure processors are in _SB scope.
Change-Id: I534f02dc50756759da945cf64d5b3623b0ec9db1 Signed-off-by: Jason Glenesk jason.glenesk@amd.corp-partner.google.com --- M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/acpi/cpu.asl 2 files changed, 24 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/44325/3
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44325 )
Change subject: soc/amd/picasso: Correct processor ACPI scope ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44325/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44325/1//COMMIT_MSG@7 PS1, Line 7: /soc/amd/picasso Correct processor scope for picasso
maybe "soc/amd/picasso: Correct processor ACPI scope"?
Done
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44325 )
Change subject: soc/amd/picasso: Correct processor ACPI scope ......................................................................
Patch Set 3: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44325 )
Change subject: soc/amd/picasso: Correct processor ACPI scope ......................................................................
soc/amd/picasso: Correct processor ACPI scope
Change namespace from _PR to _SB.
Cq-Depend: chrome-internal:3208104 BUG=b:153242529 TEST=Boot a trembyle with change applied and dump SSDTs to ensure processors are in _SB scope.
Change-Id: I534f02dc50756759da945cf64d5b3623b0ec9db1 Signed-off-by: Jason Glenesk jason.glenesk@amd.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44325 Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/acpi/cpu.asl 2 files changed, 24 insertions(+), 24 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Felix Held: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 526900a..8001b7a 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -321,7 +321,7 @@
config ACPI_CPU_STRING string - default "\_PR.C%03d" + default "\_SB.C%03d"
config ACPI_BERT bool "Build ACPI BERT Table" diff --git a/src/soc/amd/picasso/acpi/cpu.asl b/src/soc/amd/picasso/acpi/cpu.asl index 8b61b8f..eb646de 100644 --- a/src/soc/amd/picasso/acpi/cpu.asl +++ b/src/soc/amd/picasso/acpi/cpu.asl @@ -36,14 +36,14 @@ * Processor Object */ /* These devices are created at runtime */ -External (_PR.C000, DeviceObj) -External (_PR.C001, DeviceObj) -External (_PR.C002, DeviceObj) -External (_PR.C003, DeviceObj) -External (_PR.C004, DeviceObj) -External (_PR.C005, DeviceObj) -External (_PR.C006, DeviceObj) -External (_PR.C007, DeviceObj) +External (_SB.C000, DeviceObj) +External (_SB.C001, DeviceObj) +External (_SB.C002, DeviceObj) +External (_SB.C003, DeviceObj) +External (_SB.C004, DeviceObj) +External (_SB.C005, DeviceObj) +External (_SB.C006, DeviceObj) +External (_SB.C007, DeviceObj)
/* Return a package containing enabled processor entries */ Method (PPKG) @@ -51,33 +51,33 @@ If (LGreaterEqual (\PCNT, 8)) { Return (Package () { - _PR.C000, - _PR.C001, - _PR.C002, - _PR.C003, - _PR.C004, - _PR.C005, - _PR.C006, - _PR.C007 + _SB.C000, + _SB.C001, + _SB.C002, + _SB.C003, + _SB.C004, + _SB.C005, + _SB.C006, + _SB.C007 }) } ElseIf (LGreaterEqual (\PCNT, 4)) { Return (Package () { - _PR.C000, - _PR.C001, - _PR.C002, - _PR.C003 + _SB.C000, + _SB.C001, + _SB.C002, + _SB.C003 }) } ElseIf (LGreaterEqual (\PCNT, 2)) { Return (Package () { - _PR.C000, - _PR.C001 + _SB.C000, + _SB.C001 }) } Else { Return (Package () { - _PR.C000 + _SB.C000 }) } }
-
Aaron Durbin (Code Review) -
Angel Pons (Code Review)
-
Felix Held (Code Review)
-
Jason Glenesk (Code Review)