Felix Held submitted this change.
soc/amd/picasso: Correct processor ACPI scope
Change namespace from _PR to _SB.
Cq-Depend: chrome-internal:3208104
BUG=b:153242529
TEST=Boot a trembyle with change applied and dump SSDTs to ensure
processors are in _SB scope.
Change-Id: I534f02dc50756759da945cf64d5b3623b0ec9db1
Signed-off-by: Jason Glenesk <jason.glenesk@amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44325
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/soc/amd/picasso/Kconfig
M src/soc/amd/picasso/acpi/cpu.asl
2 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig
index 526900a..8001b7a 100644
--- a/src/soc/amd/picasso/Kconfig
+++ b/src/soc/amd/picasso/Kconfig
@@ -321,7 +321,7 @@
config ACPI_CPU_STRING
string
- default "\\_PR.C%03d"
+ default "\\_SB.C%03d"
config ACPI_BERT
bool "Build ACPI BERT Table"
diff --git a/src/soc/amd/picasso/acpi/cpu.asl b/src/soc/amd/picasso/acpi/cpu.asl
index 8b61b8f..eb646de 100644
--- a/src/soc/amd/picasso/acpi/cpu.asl
+++ b/src/soc/amd/picasso/acpi/cpu.asl
@@ -36,14 +36,14 @@
* Processor Object
*/
/* These devices are created at runtime */
-External (\_PR.C000, DeviceObj)
-External (\_PR.C001, DeviceObj)
-External (\_PR.C002, DeviceObj)
-External (\_PR.C003, DeviceObj)
-External (\_PR.C004, DeviceObj)
-External (\_PR.C005, DeviceObj)
-External (\_PR.C006, DeviceObj)
-External (\_PR.C007, DeviceObj)
+External (\_SB.C000, DeviceObj)
+External (\_SB.C001, DeviceObj)
+External (\_SB.C002, DeviceObj)
+External (\_SB.C003, DeviceObj)
+External (\_SB.C004, DeviceObj)
+External (\_SB.C005, DeviceObj)
+External (\_SB.C006, DeviceObj)
+External (\_SB.C007, DeviceObj)
/* Return a package containing enabled processor entries */
Method (PPKG)
@@ -51,33 +51,33 @@
If (LGreaterEqual (\PCNT, 8)) {
Return (Package ()
{
- \_PR.C000,
- \_PR.C001,
- \_PR.C002,
- \_PR.C003,
- \_PR.C004,
- \_PR.C005,
- \_PR.C006,
- \_PR.C007
+ \_SB.C000,
+ \_SB.C001,
+ \_SB.C002,
+ \_SB.C003,
+ \_SB.C004,
+ \_SB.C005,
+ \_SB.C006,
+ \_SB.C007
})
} ElseIf (LGreaterEqual (\PCNT, 4)) {
Return (Package ()
{
- \_PR.C000,
- \_PR.C001,
- \_PR.C002,
- \_PR.C003
+ \_SB.C000,
+ \_SB.C001,
+ \_SB.C002,
+ \_SB.C003
})
} ElseIf (LGreaterEqual (\PCNT, 2)) {
Return (Package ()
{
- \_PR.C000,
- \_PR.C001
+ \_SB.C000,
+ \_SB.C001
})
} Else {
Return (Package ()
{
- \_PR.C000
+ \_SB.C000
})
}
}
To view, visit change 44325. To unsubscribe, or for help writing mail filters, visit settings.