Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Paul Menzel, Eric Lai, Angel Pons, Patrick Rudolph, EricR Lai.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62723 )
Change subject: soc/intel/common: Abstract the common TCSS functions
......................................................................
Patch Set 14:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/cfg.h:
https://review.coreboot.org/c/coreboot/+/62723/comment/23874772_a9898aab
PS13, Line 30: struct soc_tcss_ops tcss_ops;
You could then add […]
Option #1 It seems compiler does not like the following setting, though the
"#include <interblocks/cfg.h" is explicitly added into the chipset.cb.
register "common_soc_config.tcss_ops" = "{
.configure_aux_bias_pads = tcss_configure_aux_bias_pads_regbar,
.valid_tbt_auth = tcss_valid_tbt_auth,
}"
Errors with "undefined reference to tcss_configure_aux_biads_pads_regbar" and "tcss_valid_tbt_auth".
There is an update with option #2.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62723
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3302aabfb5f540c41da6359f11376b4202c6310b
Gerrit-Change-Number: 62723
Gerrit-PatchSet: 14
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 29 Mar 2022 23:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment