Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Angel Pons, Werner Zeh. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63541 )
Change subject: arch/x86/postcar_loader: Correct off-by-one of MTRR end address in log ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63541/comment/075a6e94_794b4dbd PS2, Line 12: wrong
Thanks Angel. I wasn't aware of the other places but it makes sense to me having all of them consistently. I will refactor and provide a new version of this CL.
here is postcar debug print without Werner's cl:
[DEBUG] MTRR Range: Start=76000000 End=77000000 (Size 1000000) [DEBUG] MTRR Range: Start=7b800000 End=7c000000 (Size 800000) [DEBUG] MTRR Range: Start=f9000000 End=fa000000 (Size 1000000) [DEBUG] MTRR Range: Start=ff000000 End=0 (Size 1000000) [DEBUG] Normal boot
MTRR snapshot [DEBUG] 0x00000000ff000005: PHYBASE0: Address = 0x00000000ff000000, WP [DEBUG] 0x00003fffff000800: PHYMASK0: Length = 0x0000000001000000, Valid [DEBUG] 0x00000000f9000005: PHYBASE1: Address = 0x00000000f9000000, WP [DEBUG] 0x00003fffff000800: PHYMASK1: Length = 0x0000000001000000, Valid [DEBUG] 0x000000007b800006: PHYBASE2: Address = 0x000000007b800000, WB [DEBUG] 0x00003fffff800800: PHYMASK2: Length = 0x0000000000800000, Valid [DEBUG] 0x0000000076000006: PHYBASE3: Address = 0x0000000076000000, WB [DEBUG] 0x00003fffff000800: PHYMASK3: Length = 0x0000000001000000, Valid [DEBUG] 0x0000000000000000: PHYBASE4 [DEBUG] 0x0000000000000000: PHYMASK4: Disabled [DEBUG] 0x0000000000000000: PHYBASE5 [DEBUG] 0x0000000000000000: PHYMASK5: Disabled [DEBUG] 0x0000000000000000: PHYBASE6 [DEBUG] 0x0000000000000000: PHYMASK6: Disabled [DEBUG] 0x0000000000000000: PHYBASE7 [DEBUG] 0x0000000000000000: PHYMASK7: Disabled [DEBUG] 0x0000000000000000: PHYBASE8 [DEBUG] 0x0000000000000000: PHYMASK8: Disabled [DEBUG] 0x0000000000000000: PHYBASE9 [DEBUG] 0x0000000000000000: PHYMASK9: Disabled
here is postcar debug print with Werner's CL
[DEBUG] MTRR Range: Start=76000000 End=76ffffff (Size 1000000) [DEBUG] MTRR Range: Start=7b800000 End=7bffffff (Size 800000) [DEBUG] MTRR Range: Start=f9000000 End=f9ffffff (Size 1000000) [DEBUG] MTRR Range: Start=ff000000 End=ffffffff (Size 1000000)
This code change make sense to me as the MTRR start and end range is now proper where previously both the start and end were inclusive. ideally end should be always N-1.