Attention is currently required from: Felix Singer, Tim Crawford, Nico Huber, Matt DeVillier, Tim Wawrzynczak, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52139 )
Change subject: docs: correct and rewrite documentation regarding n/c / unused pads
......................................................................
Patch Set 13:
(1 comment)
File Documentation/getting_started/gpio.md:
https://review.coreboot.org/c/coreboot/+/52139/comment/f94be558_de698db3
PS13, Line 121: output, adding
`output and adding`
it's 1) setting their direction to output, (OR) 2) adding an external pull resistor or 2) configuring an internal pull resistor
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52139
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id01b197ebe8f2b8bb4ecf3d119ec2298b26d9be0
Gerrit-Change-Number: 52139
Gerrit-PatchSet: 13
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 19 Apr 2021 18:24:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment