Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Angel Pons.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63294 )
Change subject: mb/google/{brya, brask}: Disable PCH USB2 phy power gating
......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63294/comment/3269f9d2_048fe985
PS4, Line 10: to prevent possible display flicker issue
Correct, theoretical possibility and we have noticed the issue from few boards!
Ack
File src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/63294/comment/70a8b389_1bbc3093
PS5, Line 25: t
typo: Remove `t`
Ack
https://review.coreboot.org/c/coreboot/+/63294/comment/4a79ea1f_9b43b60a
PS5, Line 25: the
nit: Remove `the`
Ack
File src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/63294/comment/7c6d9616_f27dd993
PS5, Line 25: # As per Intel Advistory doc#723158, the change is required to prevent the possible
Same comments as on Brask
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25033ea218fa3154eb99af6be43c4198f4db3bcb
Gerrit-Change-Number: 63294
Gerrit-PatchSet: 5
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 08 Apr 2022 10:49:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment