Attention is currently required from: Elyes Haouas, Felix Held, Fred Reitberger, Hung-Te Lin, Intel coreboot Reviewers, Jason Glenesk, Jayvik Desai, Jeff Daly, Kapil Porwal, Martin L Roth, Matt DeVillier, Pranava Y N, Sean Rhodes, Subrata Banik, Vanessa Eusebio, Varshit Pandya, Yidi Lin, Yu-Ping Wu.
Angel Pons has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86330?usp=email )
Change subject: tree: remove duplicated includes
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File src/commonlib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/86330/comment/78646f24_4173aba5?usp... :
PS1, Line 13: #include <stdio.h>
You should remove this one instead
File src/mainboard/amd/crater/port_descriptors_renoir.c:
https://review.coreboot.org/c/coreboot/+/86330/comment/17ecb375_450b839d?usp... :
PS1, Line 11: #include <stdint.h>
Technically not duplicated, but provided by <types.h>
I would prefer to handle these separately from literal duplicates
File src/soc/mediatek/mt8196/mminfra.c:
https://review.coreboot.org/c/coreboot/+/86330/comment/123c6172_485bc0f1?usp... :
PS1, Line 8: #include <stddef.h>
Same here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86330?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaf10e1b9fb8ce51605a75ec0a92ee33924c42aa6
Gerrit-Change-Number: 86330
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 08 Feb 2025 09:55:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes