Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Julian Schroeder has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56188 )
Change subject: soc/amd/cezanne: add ACPI CPPC support for AMD
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56188/comment/1b84f119_06b319e3
PS4, Line 9: CollaborativeProcessorPerformanceControl
: See also: uefi.org/specifications
: This leverages the existing CPPC support and adds a
: cppc init for AMD/Cezanne.
:
maybe: […]
Done
Patchset:
PS4:
all change requests done
File src/soc/amd/cezanne/cppc.c:
https://review.coreboot.org/c/coreboot/+/56188/comment/cfc9daca_15f303e3
PS4, Line 168: int
unsigned int?
Done
File src/soc/amd/cezanne/include/soc/cppc.h:
PS4:
i'd put the msr number and bit defines in oc/amd/cezanne/include/soc/msr. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56188
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94172f40c7fa4b7b89237fd382448e598da00fbb
Gerrit-Change-Number: 56188
Gerrit-PatchSet: 4
Gerrit-Owner: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 13 Jul 2021 19:51:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment