Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78896?usp=email )
Change subject: soc/amd/genoa/devicetree: fix MMIO base addresses ......................................................................
soc/amd/genoa/devicetree: fix MMIO base addresses
The base addresses of I2C 5 and I3C 3 were wrong and all I3C controllers should use the base address of the 4kiB block where all registers of that I3C controller are located in. PPR #55901 Rev 0.26 was used as a reference.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I1c983d4a709000ef7963b96228322603b98728aa --- M src/soc/amd/genoa/chipset.cb 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/78896/1
diff --git a/src/soc/amd/genoa/chipset.cb b/src/soc/amd/genoa/chipset.cb index 45eeec7..8b7d39e 100644 --- a/src/soc/amd/genoa/chipset.cb +++ b/src/soc/amd/genoa/chipset.cb @@ -213,13 +213,13 @@ device mmio 0xfedc4000 alias i2c_2 off end device mmio 0xfedc5000 alias i2c_3 off end device mmio 0xfedc6000 alias i2c_4 off end - device mmio 0xfedc7000 alias i2c_5 off end + device mmio 0xfedcb000 alias i2c_5 off end device mmio 0xfedc9000 alias uart_0 off end device mmio 0xfedca000 alias uart_1 off end device mmio 0xfedce000 alias uart_2 off end - device mmio 0xfedd2600 alias i3c_0 off end - device mmio 0xfedd3600 alias i3c_1 off end - device mmio 0xfedd4600 alias i3c_2 off end - device mmio 0xfedd5600 alias i3c_3 off end + device mmio 0xfedd2000 alias i3c_0 off end + device mmio 0xfedd3000 alias i3c_1 off end + device mmio 0xfedd4000 alias i3c_2 off end + device mmio 0xfedd6000 alias i3c_3 off end
end