Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/29343 )
Change subject: soc/amd/stoneyridge: Set IOMMU support to follow device setting ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/29343/1/src/soc/amd/common/block/pi/agesawra... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/29343/1/src/soc/amd/common/block/pi/agesawra... PS1, Line 328: if (!dev->enabled
if (dev->enabled) ?
nit: if(dev && dev->enabled)
https://review.coreboot.org/#/c/29343/1/src/soc/amd/stoneyridge/northbridge.... File src/soc/amd/stoneyridge/northbridge.c:
https://review.coreboot.org/#/c/29343/1/src/soc/amd/stoneyridge/northbridge.... PS1, Line 513: dev->enabled similar nit for dev=0.