Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44893 )
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
mb/google/zork: update GPIO config for berknip
berknip does not support stylus, config AGPIO4 to NC to prevent unexpected wake event for s3.
BUG=b:162376046 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: I8d9b711ce1d7300181fe496d490dd33b38bc5983 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/gpio.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/44893/1
diff --git a/src/mainboard/google/zork/variants/berknip/gpio.c b/src/mainboard/google/zork/variants/berknip/gpio.c index 8abe59f..110468a 100644 --- a/src/mainboard/google/zork/variants/berknip/gpio.c +++ b/src/mainboard/google/zork/variants/berknip/gpio.c @@ -8,6 +8,8 @@ #include <ec/google/chromeec/ec.h>
static const struct soc_amd_gpio berknip_bid1_gpio_set_stage_ram[] = { + /* PEN_DETECT_ODL */ + PAD_NC(GPIO_4), /* DMIC_SEL */ PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic /* USB_OC4_L - USB_A1 */ @@ -29,6 +31,8 @@ };
static const struct soc_amd_gpio berknip_bid2_gpio_set_stage_ram[] = { + /* PEN_DETECT_ODL */ + PAD_NC(GPIO_4), /* EN_DEV_BEEP_L */ PAD_GPO(GPIO_89, HIGH), /* TP */
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44893 )
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44893/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/gpio.c:
https://review.coreboot.org/c/coreboot/+/44893/1/src/mainboard/google/zork/v... PS1, Line 13: /* DMIC_SEL */ GPIO_5 should also be configured as PAD_NC since it is unused on berknip.
https://review.coreboot.org/c/coreboot/+/44893/1/src/mainboard/google/zork/v... PS1, Line 43: You will also need a default berkbip_gpio_set_stage_ram[] and configure GPIO_4 and GPIO_5 as PAD_NC. This will have to be returned for board versions > 2 below.
https://review.coreboot.org/c/coreboot/+/44893/1/src/mainboard/google/zork/v... PS1, Line 64: *size = 0; Here, instead of 0 and NULL, you will have to return sizeof(berkbip_gpio_set_stage_ram) and berkbip_gpio_set_stage_ram.
Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Patrick Georgi, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44893
to look at the new patch set (#2).
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
mb/google/zork: update GPIO config for berknip
berknip does not support stylus, config AGPIO4 to NC to prevent unexpected wake event for s3.
BUG=b:162376046 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: I8d9b711ce1d7300181fe496d490dd33b38bc5983 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/gpio.c 1 file changed, 17 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/44893/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44893 )
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44893/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/gpio.c:
https://review.coreboot.org/c/coreboot/+/44893/2/src/mainboard/google/zork/v... PS2, Line 49: /* PEN_DETECT_ODL - no used */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44893/2/src/mainboard/google/zork/v... PS2, Line 50: PAD_NC(GPIO_4), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44893/2/src/mainboard/google/zork/v... PS2, Line 50: PAD_NC(GPIO_4), please, no spaces at the start of a line
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44893 )
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44893/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/gpio.c:
https://review.coreboot.org/c/coreboot/+/44893/1/src/mainboard/google/zork/v... PS1, Line 13: /* DMIC_SEL */
GPIO_5 should also be configured as PAD_NC since it is unused on berknip.
Done
https://review.coreboot.org/c/coreboot/+/44893/1/src/mainboard/google/zork/v... PS1, Line 43:
You will also need a default berkbip_gpio_set_stage_ram[] and configure GPIO_4 and GPIO_5 as PAD_NC. […]
Done
https://review.coreboot.org/c/coreboot/+/44893/1/src/mainboard/google/zork/v... PS1, Line 64: *size = 0;
Here, instead of 0 and NULL, you will have to return sizeof(berkbip_gpio_set_stage_ram) and berkbip_ […]
Done
Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Patrick Georgi, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44893
to look at the new patch set (#3).
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
mb/google/zork: update GPIO config for berknip
berknip does not support stylus, config AGPIO4/5 to NC to prevent unexpected wake event for s3.
BUG=b:162376046 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: I8d9b711ce1d7300181fe496d490dd33b38bc5983 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/gpio.c 1 file changed, 17 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/44893/3
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44893 )
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44893/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/gpio.c:
https://review.coreboot.org/c/coreboot/+/44893/3/src/mainboard/google/zork/v... PS3, Line 49: /* PEN_DETECT_ODL - no used */ : PAD_NC(GPIO_4), these 2 lines need a tab for indention.
Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Patrick Georgi, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44893
to look at the new patch set (#4).
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
mb/google/zork: update GPIO config for berknip
berknip does not support stylus, config AGPIO4/5 to NC to prevent unexpected wake event for s3.
BUG=b:162376046 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: I8d9b711ce1d7300181fe496d490dd33b38bc5983 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/gpio.c 1 file changed, 17 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/44893/4
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44893 )
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44893/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/gpio.c:
https://review.coreboot.org/c/coreboot/+/44893/3/src/mainboard/google/zork/v... PS3, Line 49: /* PEN_DETECT_ODL - no used */ : PAD_NC(GPIO_4),
these 2 lines need a tab for indention.
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44893 )
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
Patch Set 4: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44893 )
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44893 )
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
mb/google/zork: update GPIO config for berknip
berknip does not support stylus, config AGPIO4/5 to NC to prevent unexpected wake event for s3.
BUG=b:162376046 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: I8d9b711ce1d7300181fe496d490dd33b38bc5983 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44893 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/berknip/gpio.c 1 file changed, 17 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/berknip/gpio.c b/src/mainboard/google/zork/variants/berknip/gpio.c index 8abe59f..c8cb10f 100644 --- a/src/mainboard/google/zork/variants/berknip/gpio.c +++ b/src/mainboard/google/zork/variants/berknip/gpio.c @@ -8,6 +8,10 @@ #include <ec/google/chromeec/ec.h>
static const struct soc_amd_gpio berknip_bid1_gpio_set_stage_ram[] = { + /* PEN_DETECT_ODL - no used */ + PAD_NC(GPIO_4), + /* PEN_POWER_EN - no used */ + PAD_NC(GPIO_5), /* DMIC_SEL */ PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic /* USB_OC4_L - USB_A1 */ @@ -29,6 +33,10 @@ };
static const struct soc_amd_gpio berknip_bid2_gpio_set_stage_ram[] = { + /* PEN_DETECT_ODL - no used */ + PAD_NC(GPIO_4), + /* PEN_POWER_EN - no used */ + PAD_NC(GPIO_5), /* EN_DEV_BEEP_L */ PAD_GPO(GPIO_89, HIGH), /* TP */ @@ -37,6 +45,13 @@ PAD_GPO(GPIO_140, HIGH), };
+static const struct soc_amd_gpio berknip_gpio_set_stage_ram[] = { + /* PEN_DETECT_ODL - no used */ + PAD_NC(GPIO_4), + /* PEN_POWER_EN - no used */ + PAD_NC(GPIO_5), +}; + const struct soc_amd_gpio *variant_override_gpio_table(size_t *size) { uint32_t board_version; @@ -57,6 +72,6 @@ return berknip_bid2_gpio_set_stage_ram; }
- *size = 0; - return NULL; + *size = ARRAY_SIZE(berknip_gpio_set_stage_ram); + return berknip_gpio_set_stage_ram; }
-
Aaron Durbin (Code Review) -
build bot (Jenkins) (Code Review)
-
Furquan Shaikh (Code Review)
-
Kevin Chiu (Code Review)
-
Patrick Georgi (Code Review)