Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43213 )
Change subject: security/vboot/secdata_tpm.c: Drop dead code ......................................................................
security/vboot/secdata_tpm.c: Drop dead code
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: Ie01d65f80caf32a8318d5109ad48321661c5a87b Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/security/vboot/secdata_tpm.c 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/43213/1
diff --git a/src/security/vboot/secdata_tpm.c b/src/security/vboot/secdata_tpm.c index d350b38..dcb3c44 100644 --- a/src/security/vboot/secdata_tpm.c +++ b/src/security/vboot/secdata_tpm.c @@ -13,13 +13,8 @@ #include <vb2_api.h> #include <console/console.h>
-#ifdef FOR_TEST -#include <stdio.h> -#define VBDEBUG(format, args...) printf(format, ## args) -#else #define VBDEBUG(format, args...) \ printk(BIOS_INFO, "%s():%d: " format, __func__, __LINE__, ## args) -#endif
#define RETURN_ON_FAILURE(tpm_cmd) do { \ uint32_t result_; \
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43213 )
Change subject: security/vboot/secdata_tpm.c: Drop dead code ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43213 )
Change subject: security/vboot/secdata_tpm.c: Drop dead code ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43213 )
Change subject: security/vboot/secdata_tpm.c: Drop dead code ......................................................................
security/vboot/secdata_tpm.c: Drop dead code
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: Ie01d65f80caf32a8318d5109ad48321661c5a87b Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43213 Reviewed-by: Julius Werner jwerner@chromium.org Reviewed-by: Michael Niewöhner Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/security/vboot/secdata_tpm.c 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/security/vboot/secdata_tpm.c b/src/security/vboot/secdata_tpm.c index d350b38..dcb3c44 100644 --- a/src/security/vboot/secdata_tpm.c +++ b/src/security/vboot/secdata_tpm.c @@ -13,13 +13,8 @@ #include <vb2_api.h> #include <console/console.h>
-#ifdef FOR_TEST -#include <stdio.h> -#define VBDEBUG(format, args...) printf(format, ## args) -#else #define VBDEBUG(format, args...) \ printk(BIOS_INFO, "%s():%d: " format, __func__, __LINE__, ## args) -#endif
#define RETURN_ON_FAILURE(tpm_cmd) do { \ uint32_t result_; \
-
Angel Pons (Code Review) -
Julius Werner (Code Review)
-
Michael Niewöhner (Code Review)