Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43212 )
Change subject: security/tpm/tss/tcg-1.2/tss.c: Drop dead code ......................................................................
security/tpm/tss/tcg-1.2/tss.c: Drop dead code
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: Ifda2bbd87cd8ef5ec8e449d2c4d303be37b4d7c7 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/security/tpm/tss/tcg-1.2/tss.c 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/43212/1
diff --git a/src/security/tpm/tss/tcg-1.2/tss.c b/src/security/tpm/tss/tcg-1.2/tss.c index 4434ca6..30cd1cc 100644 --- a/src/security/tpm/tss/tcg-1.2/tss.c +++ b/src/security/tpm/tss/tcg-1.2/tss.c @@ -21,13 +21,8 @@ #include "tss_internal.h" #include "tss_commands.h"
-#ifdef FOR_TEST -#include <stdio.h> -#define VBDEBUG(format, args...) printf(format, ## args) -#else #include <console/console.h> #define VBDEBUG(format, args...) printk(BIOS_DEBUG, format, ## args) -#endif
static int tpm_send_receive(const uint8_t *request, uint32_t request_length,
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43212 )
Change subject: security/tpm/tss/tcg-1.2/tss.c: Drop dead code ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43212 )
Change subject: security/tpm/tss/tcg-1.2/tss.c: Drop dead code ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43212 )
Change subject: security/tpm/tss/tcg-1.2/tss.c: Drop dead code ......................................................................
security/tpm/tss/tcg-1.2/tss.c: Drop dead code
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: Ifda2bbd87cd8ef5ec8e449d2c4d303be37b4d7c7 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43212 Reviewed-by: Julius Werner jwerner@chromium.org Reviewed-by: Michael Niewöhner Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/security/tpm/tss/tcg-1.2/tss.c 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/security/tpm/tss/tcg-1.2/tss.c b/src/security/tpm/tss/tcg-1.2/tss.c index 4434ca6..30cd1cc 100644 --- a/src/security/tpm/tss/tcg-1.2/tss.c +++ b/src/security/tpm/tss/tcg-1.2/tss.c @@ -21,13 +21,8 @@ #include "tss_internal.h" #include "tss_commands.h"
-#ifdef FOR_TEST -#include <stdio.h> -#define VBDEBUG(format, args...) printf(format, ## args) -#else #include <console/console.h> #define VBDEBUG(format, args...) printk(BIOS_DEBUG, format, ## args) -#endif
static int tpm_send_receive(const uint8_t *request, uint32_t request_length,
-
Angel Pons (Code Review) -
Julius Werner (Code Review)
-
Michael Niewöhner (Code Review)