Attention is currently required from: Bora Guvendik, Intel coreboot Reviewers, Jérémy Compostella, Kyoung Il Kim, Paul Menzel, Subrata Banik.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85198?usp=email )
Change subject: drivers/intel/touch: Add Intel Touch Controller driver ......................................................................
Patch Set 12:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85198/comment/54df7356_234dab9a?usp... : PS12, Line 26:
Does the driver log something? Any hints how to debug the driver?
Acknowledged.
File src/drivers/intel/touch/chip.h:
https://review.coreboot.org/c/coreboot/+/85198/comment/6da8d61a_24dce1bb?usp... : PS12, Line 15: uint64_t connection_speed;
What is the unit?
Acknowledged
https://review.coreboot.org/c/coreboot/+/85198/comment/330951bf_3232545a?usp... : PS12, Line 183: /* Delay to be inserted after device is taken out of reset. */
No dot at the end (also above and below).
Acknowledged
File src/drivers/intel/touch/elan.h:
https://review.coreboot.org/c/coreboot/+/85198/comment/03b549d6_aba369b5?usp... : PS12, Line 17: #define ELAN_RST_SEQ_DLY 300
Please add the unit to the name.
unit commented in line 14 should be sufficient.
https://review.coreboot.org/c/coreboot/+/85198/comment/1334dae9_2b682bdd?usp... : PS12, Line 45: 2C Fast
Missing I?
Acknowledged