Attention is currently required from: John Zhao, Tim Wawrzynczak, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63159 )
Change subject: soc/intel/common: Add Kconfig SOC_INTEL_CSE_SET_EOP
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Yes, while rebasing for platform (which does not select this Kconfig SOC_INTEL_CSE_EOP) build, it runs into compilation as do_send_end_of_post function is defined in the cse_eop.c file.
any reason you see, why coreboot SoC won't select this Kconfig, I would like to understand if we really need to merge this CL, because we have dedicated that coreboot won't call into FSP-notifyphase APIs hence, sending EOP from coreboot native driver is mandatory now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63159
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib52404d9ad4c01a460e4cfef331c529d2a53337a
Gerrit-Change-Number: 63159
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 29 Mar 2022 05:24:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Gerrit-MessageType: comment